ng2-tree icon indicating copy to clipboard operation
ng2-tree copied to clipboard

Not compatible with rxjs 6.3.2 anymore

Open normantimorehl opened this issue 5 years ago • 3 comments

Dear support team,

we updated our solution to Angular core 6.1.8 and rxjs 6.3.2 and now we have compilation errors for the ng2-tree component:

ERROR in ./node_modules/ng2-tree/src/tree.js Module not found: Error: Can't resolve 'rxjs/Observable' in 'MYSRCPATH\node_modules\ng2-tree\src' ERROR in ./node_modules/ng2-tree/src/tree.service.js Module not found: Error: Can't resolve 'rxjs/Subject' in 'MYSRCPATH\node_modules\ng2-tree\src' ERROR in ./node_modules/ng2-tree/src/draggable/node-draggable.service.js Module not found: Error: Can't resolve 'rxjs/Subject' in 'MYSRCPATH\node_modules\ng2-tree\src\draggable' ERROR in ./node_modules/ng2-tree/src/menu/node-menu.service.js Module not found: Error: Can't resolve 'rxjs/Subject' in 'MYSRCPATH\node_modules\ng2-tree\src\menu' ERROR in ./node_modules/ng2-tree/src/rxjs-imports.js Module not found: Error: Can't resolve 'rxjs/add/observable/of' in 'MYSRCPATH\node_modules\ng2-tree\src' ERROR in ./node_modules/ng2-tree/src/rxjs-imports.js Module not found: Error: Can't resolve 'rxjs/add/operator/filter' in 'MYSRCPATH\node_modules\ng2-tree\src' ERROR in ./node_modules/ng2-tree/src/rxjs-imports.js Module not found: Error: Can't resolve 'rxjs/add/operator/merge' in 'MYSRCPATH\node_modules\ng2-tree\src'

So I think an rework is necessary to fix these issue.

Kind regards Norman Timo

normantimorehl avatar Sep 24 '18 06:09 normantimorehl

Hi all, i have the same issue with rxjs version 6.0.3 and Angular 6.1.8; any update ?

Thanks

Naikno avatar Sep 26 '18 16:09 Naikno

I fixed it installing rxjs compat: npm install rxjs-compat

Naikno avatar Sep 26 '18 16:09 Naikno

Hi Naikno,

rxjs-compat is not a solution for me. This is only if you can't change the ng2-tre or you are too lazy to do the necessary changes.

Finally the dev-team is too slow for our project and with these issues so I embedded the source code in my project and made the necessary changes alone.

Mainly you have to change the import clauses for rxjs operators. And on two source code lines you have to change the concatinations of rxjs operators to the new pipe construction. All necessary things are described here: academind - rxjs-6-what-changed

Kind regards norman_timo

normantimorehl avatar Sep 26 '18 16:09 normantimorehl