ng2-file-upload icon indicating copy to clipboard operation
ng2-file-upload copied to clipboard

Angular V17 support

Open serderovsh opened this issue 1 year ago • 10 comments

Hi. Please add support for Angular 17

serderovsh avatar Nov 19 '23 18:11 serderovsh

@serderovsh: As I am not quite sure when this will get upgraded and we need it badly, I have forked and published a new version. Check out @augwit/ng2-file-upload@^6.0.0.

That fork is only for Angular upgrades, no other features and bug fixes are intended to be done.

iconben avatar Nov 28 '23 10:11 iconben

Adding something like

"overrides": {
    "ng2-file-upload": {
      "@angular/common": "17.0.4",
      "@angular/core": "17.0.4"
    }
}

to package.json could also be used as a stopgap measure.

cardamon avatar Nov 29 '23 08:11 cardamon

Adding something like

"overrides": {
    "ng2-file-upload": {
      "@angular/common": "17.0.4",
      "@angular/core": "17.0.4"
    }
}

to package.json could also be used as a stopgap measure.

I used the following, which ties it to the version you otherwise have installed (so you don't have to muck with the versions manually over time). Thanks for the tip!

"overrides": {
    "ng2-file-upload": {
      "@angular/common": "$@angular/common",
      "@angular/core": "$@angular/core"
    }
}

hamfastgamgee avatar Nov 30 '23 18:11 hamfastgamgee

Adding something like

"overrides": {
    "ng2-file-upload": {
      "@angular/common": "17.0.4",
      "@angular/core": "17.0.4"
    }
}

to package.json could also be used as a stopgap measure.

This is a great tip! Thanks!!!

JamesonNetworks avatar Dec 23 '23 23:12 JamesonNetworks

Adding something like

"overrides": {
    "ng2-file-upload": {
      "@angular/common": "17.0.4",
      "@angular/core": "17.0.4"
    }
}

to package.json could also be used as a stopgap measure.

I used the following, which ties it to the version you otherwise have installed (so you don't have to muck with the versions manually over time). Thanks for the tip!

"overrides": {
    "ng2-file-upload": {
      "@angular/common": "$@angular/common",
      "@angular/core": "$@angular/core"
    }
}

this is great but we need native support! ;-)

plz @valorkin !

WuglyakBolgoink avatar Jan 26 '24 15:01 WuglyakBolgoink

ofc, please do a PR and mention me

valorkin avatar Jan 30 '24 22:01 valorkin

So Angular 17 support is done, right? https://github.com/valor-software/ng2-file-upload/pull/1266

Can we get a release please @valorkin ? :)

FrontendJesus avatar Feb 20 '24 14:02 FrontendJesus

Any updates on this? I'm still using the trick of overriding the library dependencies.

danilobassi8 avatar Mar 13 '24 19:03 danilobassi8