ng2-dragula icon indicating copy to clipboard operation
ng2-dragula copied to clipboard

[usage question] Purpuse of shipping two package.json files

Open vladimiry opened this issue 6 years ago • 3 comments

REQUIRED: Before filing a usage question

Change each [ ] to [x] when you have done it.

Use case description (required)

The npm published package doesn't seem to be compatible with to be released soon Ivy Renderer (Renderer3). See this issue https://github.com/angular/angular/issues/29703 for details.

Is there any special purpose in shipping two package.json files?

vladimiry avatar Apr 05 '19 07:04 vladimiry

Will accept a PR that changes it to use ng-packagr.

cormacrelf avatar Apr 25 '19 01:04 cormacrelf

@cormacrelf I just hit the original issue described here and was going to contribute a fix, but it looks like there's nothing to change. Just when publishing you need to do npm publish modules/ng2-dragula/dist instead of npm publish modules/ng2-dragula and everything should just work. Any chance you could publish a new version with that change? Thanks! 😄

Edit: I didn't spot you were using lerna to publish, I just sent a small patch your way that should make the required changes for this to work: https://github.com/valor-software/ng2-dragula/pull/962

mattlewis92 avatar May 31 '19 23:05 mattlewis92

Hi,

do you know when you plan on releasing the fix? This tiny issue prevent me to test if ivy works for me :-)

Thanks

ssougnez avatar Jun 08 '19 11:06 ssougnez