DoesTheDogWatchPlex icon indicating copy to clipboard operation
DoesTheDogWatchPlex copied to clipboard

dockerfile + wrapper script

Open yacn opened this issue 6 years ago • 1 comments

Addresses #2

changes

  • Updates build_json.py to take in as a commandline argument the path to write the JSON update file. This is useful for the running the project within a container.

  • Updates write_to_plex.py to take in the path to the JSON update file as an argument.

  • Adds Dockerfile for building a containerized version of this project.

  • Adds a wrapper script run-in-docker.py that wraps building the container from the Dockerfile as well as running the two scripts inside the container

testing

I've verified that docker image building and running build_json.py work successfully. As I myself do not need this info in the movie descriptions and have a rather large library who's DB I don't have backed up, I did not test out write_to_plex.py.

todo

However I will look into running a copy of my plex server's DB in a local testing container to test write_to_plex.py against. This might even be able to be extracted into a generic integration test that the project could run against in Travis or the like.

also wanted to say i really like the idea of making this a plex metadata agent but i'd be hesitant investing time and effort into doing so since it seems like plex is phasing out that ability: https://www.reddit.com/r/PleX/comments/9n9qjl/subzero_the_future/ . As niche as it is, jellyfin might be a better target for that effort, though that would require a re-write in a dot Net language or verifying this works under IronPython so who knows.

yacn avatar Aug 12 '19 18:08 yacn

Hi,

I would be hesitant about merging this until I can have write_to_plex verified working within Docker. If someone can test this and report back, that would be fabulous.

valknight avatar Aug 26 '19 14:08 valknight