valkey-io
Fix aof base suffix when modifying aof-use-rdb-preamble during rewrite
If we modify aof-use-rdb-preamble in the middle of rewrite, we may get a wrong aof base suffix. This is because the suffix is concatenated by the main process afterwards, and it may be different from the beginning.
We cache this value when we start the rewrite.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.38%. Comparing base (
7424620) to head (7963ce1). Report is 76 commits behind head on unstable.
Additional details and impacted files
@@ Coverage Diff @@
## unstable #886 +/- ##
============================================
- Coverage 70.39% 70.38% -0.02%
============================================
Files 112 112
Lines 61465 61467 +2
============================================
- Hits 43271 43263 -8
- Misses 18194 18204 +10
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/aof.c | 80.07% <100.00%> (+0.01%) |
:arrow_up: |
| src/server.h | 100.00% <ø> (ø) |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Looks good. Another option is to reject the config change during rewrite?
Another option is to reject the config change during rewrite?
yes, this also make sense, the two options work for me, there is another discusstion in #887
Another option is to reject the config change during rewrite?
This may be a breaking change in some ways, @zuiderkwast i am going to keep this one, do you have other thoughts?