valkey icon indicating copy to clipboard operation
valkey copied to clipboard

[Feat] Support fast fail option for tcl test cases

Open arthurkiller opened this issue 1 year ago • 2 comments

Hi, new here in valkey community.

This PR added a new option for tcl test case which will fail fast once any test cases fail. This can be useful while running redis CI pipeline, and you want to accelerate the CI pipeline.

Appreciate all the things you guys have done, hope can contribute to this project.

arthurkiller avatar May 07 '24 12:05 arthurkiller

usage for example

./runtest --single unit/type/hash --fastfail

[ok]: HSET/HLEN - Small hash creation (2 ms)
[ok]: Is the small hash encoded with a listpack? (0 ms)
[ok]: HRANDFIELD - listpack (8 ms)
[ok]: HRANDFIELD - hashtable (7 ms)
Test error (last server port:21113, log:./tests/tmp/server.3935664.1/stdout), test will exit now
[err]: HRANDFIELD with RESP3 in tests/unit/type/hash.tcl
Expected '3' to be equal to '2333' (context: type eval line 8 cmd {assert_equal [llength $res] 2333} proc ::test)
(Fastfail: test will exit now)

arthurkiller avatar May 07 '24 12:05 arthurkiller

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.92%. Comparing base (ba9dd7b) to head (20239f9).

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #452      +/-   ##
============================================
- Coverage     68.95%   68.92%   -0.03%     
============================================
  Files           109      109              
  Lines         61793    61793              
============================================
- Hits          42611    42593      -18     
- Misses        19182    19200      +18     

see 13 files with indirect coverage changes

codecov[bot] avatar May 07 '24 14:05 codecov[bot]