valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Migrate cluster mode tests to normal framework

Open enjoy-binbin opened this issue 1 year ago • 1 comments

We currently has two disjoint TCL frameworks:

  1. Normal testing framework, which trigger by runtest, which individually launches nodes for testing.
  2. Cluster framework, which trigger by runtest-cluster, which pre-allocates N nodes and uses them for testing large configurations.

The normal TCL testing framework is much more readily tested and is also automatically run as part of the CI for new PRs. The runtest-cluster since it runs very slowly (cannot be parallelized), it currently only runs in daily CI, this results in some changes to the cluster not being exposed in PR CI in time.

This PR migrate the Cluster mode tests to normal framework. Some cluster tests are kept in runtest-cluster because of timing issues or not yet supported, we can process them later.

enjoy-binbin avatar May 06 '24 04:05 enjoy-binbin

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.83%. Comparing base (4e944ce) to head (e1fb7ed).

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #442      +/-   ##
============================================
+ Coverage     68.88%   69.83%   +0.94%     
============================================
  Files           109      109              
  Lines         61793    61793              
============================================
+ Hits          42566    43153     +587     
+ Misses        19227    18640     -587     

see 23 files with indirect coverage changes

codecov[bot] avatar May 06 '24 04:05 codecov[bot]