valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Rename redis in aof logs and proc title redis-aof-rewrite to valkey-aof-rewrite.

Open Shivshankar-Reddy opened this issue 1 year ago • 2 comments

Renamed redis to valkey/server in aof.c serverlogs and child proc title redis-aof-rewrite -> valkey-aof-rewrite.

This is a breaking chnages since logs are changed.

Part of #207.

Shivshankar-Reddy avatar Apr 26 '24 15:04 Shivshankar-Reddy

TSC had a discussion on this topic (#361)

The rule of thumb is that command error messages should be retained for backward compatibility. Log lines are in general OK to change. We haven't discussed the proc title; though I consider it much closer to logs (hence safe to change). @zuiderkwast thoughts?

PingXie avatar Apr 26 '24 17:04 PingXie

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 68.42%. Comparing base (19c4c64) to head (00d7cb5). Report is 11 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #393      +/-   ##
============================================
+ Coverage     68.35%   68.42%   +0.06%     
============================================
  Files           108      109       +1     
  Lines         61563    61671     +108     
============================================
+ Hits          42084    42198     +114     
+ Misses        19479    19473       -6     
Files Coverage Δ
src/cluster_legacy.c 74.56% <ø> (-0.28%) :arrow_down:
src/aof.c 80.79% <40.00%> (-0.12%) :arrow_down:

... and 18 files with indirect coverage changes

codecov[bot] avatar Apr 29 '24 19:04 codecov[bot]