valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Removing Redis from internal lua function names and comments

Open parthpatel opened this issue 10 months ago • 3 comments

  • Fixed a bug where 'server *' invocation from lua debugger was not working. Manually tested it as follows -
Before 

lua debugger> redis ping
<redis> ping
<reply> "+PONG"
lua debugger> server ping
<error> Unknown Redis Lua debugger command or wrong number of arguments.

After

% ./src/valkey-cli --ldb --eval /tmp/1
* Stopped at 1, stop reason = step over
-> 1   return redis.call('ping');
lua debugger> server ping
<redis> ping
<reply> "+PONG"
  • Functions in lua c files lack of documentation. Adding some documentation in this commit.
  • I removed Redis from function names in eval.c and script_lua.c files. I did not touch log messages in this commit. I also did not touch references to "RedisProtocol".

parthpatel avatar Apr 10 '24 21:04 parthpatel

Generally, can you split this into two PRs.

  1. Strictly what we need to backport.
  2. Everything else. I think all your suggestions are pretty good, they will just be a bit annoying to backport since they are so widespread.

Agreed. I will split it, so that the bugfix is easier to backport.

parthpatel avatar Apr 11 '24 02:04 parthpatel

I accidentally closed this review while resetting the branch, new to github workflows. Reopening this PR. I will take care of the comments a little later in the day.

parthpatel avatar Apr 11 '24 23:04 parthpatel

@parthpatel Are you still planning to work on this?

madolson avatar May 13 '24 00:05 madolson