valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Make the COB soft limit also use repl-backlog-size when its value is smaller

Open enjoy-binbin opened this issue 1 month ago • 1 comments

We have the same settings for the hard limit, and we should apply them to the soft limit as well. When the repl-backlog-size value is larger, all replication buffers can be handled by the replication backlog, so there's no need to worry about the client output buffer soft limit in here. Furthermore, when soft_seconds is 0, in some ways, the soft limit behaves the same (mostly) as the hard limit.

enjoy-binbin avatar Nov 24 '25 14:11 enjoy-binbin

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 72.46%. Comparing base (8ea7f13) to head (16fa29f). :warning: Report is 22 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2866      +/-   ##
============================================
+ Coverage     72.44%   72.46%   +0.02%     
============================================
  Files           128      128              
  Lines         70415    70417       +2     
============================================
+ Hits          51011    51027      +16     
+ Misses        19404    19390      -14     
Files with missing lines Coverage Δ
src/networking.c 88.44% <100.00%> (+<0.01%) :arrow_up:

... and 13 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 24 '25 15:11 codecov[bot]

This seem safe so i am going to merge, please feel free to leave a comment if you think otherwise.

enjoy-binbin avatar Dec 08 '25 04:12 enjoy-binbin