replace strcmp with byte-by-byte comparison in aof

[MuradSh]

Issue #2792

Replace strcmp with byte-by-byte comparison to avoid accidental heap-buffer-overflow errors.

[sarthakaggarwal97]

Do you mean https://github.com/valkey-io/valkey/issues/2792 in the PR description?

[MuradSh]

Oops, yeah. I updated the description.

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 72.43%. Comparing base (32844b8) to head (7c456b5). :warning: Report is 47 commits behind head on unstable.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #2809      +/-   ##
============================================
+ Coverage     72.41%   72.43%   +0.02%     
============================================
  Files           128      128              
  Lines         70261    70261              
============================================
+ Hits          50879    50897      +18     
+ Misses        19382    19364      -18     

Files with missing lines	Coverage Δ
src/valkey-check-aof.c	73.80% <100.00%> (ø)

... and 9 files with indirect coverage changes

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[zuiderkwast]

Do we need to backport this fix? To which versions?