valkey icon indicating copy to clipboard operation
valkey copied to clipboard

updated modules examples to compile on Valkey 7.2 branch

Open dmitrypol opened this issue 2 months ago • 6 comments

  • Back-port of https://github.com/valkey-io/valkey/pull/342 to make modules examples work on Valkey 7.2
  • Back-port https://github.com/valkey-io/valkey/pull/349 to fix module tests
  • And back-port https://github.com/valkey-io/valkey/pull/815 to fix CI jobs

dmitrypol avatar Nov 02 '25 19:11 dmitrypol

Hi @dmitrypol, can you add a description to the PR explaining why this change is needed in 7.2 branch? Is this a simple backport of https://github.com/valkey-io/valkey/pull/342 ?

rjd15372 avatar Nov 03 '25 08:11 rjd15372

@rjd15372 - do you have any experience with these CI failures? I am able to run all tests locally

dmitrypol avatar Nov 03 '25 13:11 dmitrypol

I looked into the notification job failure, looks like we have not backported the change here: https://github.com/valkey-io/valkey/pull/815

on 7.2 branch the job trigger looks like this:

notify-about-job-results:
    runs-on: ubuntu-latest
    if: always() && github.event_name != 'workflow_dispatch' && github.repository == 'valkey-io/valkey'

but we need it to be like

if: always() && github.event_name == 'schedule' && github.repository == 'valkey-io/valkey'

roshkhatri avatar Nov 05 '25 19:11 roshkhatri

thank you @roshkhatri . Backported the change for CI, hopefully this fixes the build

dmitrypol avatar Nov 06 '25 00:11 dmitrypol

you mean backport this PR to 7.2 version?

hwware avatar Nov 13 '25 19:11 hwware

@hwware - yes, I am backporting a PR to Valkey 7.2 to get the default modules to compile

dmitrypol avatar Nov 13 '25 19:11 dmitrypol