valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Fix cluster_config_consistent proc of tcl tests

Open VoletiRam opened this issue 1 year ago • 1 comments

Fix cluster_config_consistent proc of tcl tests by verifying the node status to be online. We expect the start_server to create the desired primaries and replicas before the start of the tests. With the current setup, the replicas may not complete the sync with primaries and can be in loading state. In some cases, the role of replicas can still be master with the delay of propagation of replicate command. The tests can show flaky behavior in such cases. Add a check that verifies the nodes health status 'online' for the cluster consistency. Leverage the deterministic order of CLUSTER SLOTS to consider the cluster as consistent along with the nodes health status.

VoletiRam avatar Apr 08 '24 22:04 VoletiRam

@zuiderkwast Here's the fix + tcl test coverage for https://github.com/valkey-io/valkey/pull/265

hpatro avatar Apr 08 '24 22:04 hpatro