Usage of MASTER in module reference

Open madolson opened this issue 1 year ago • 1 comments

We still have a usage of master in modules, https://github.com/valkey-io/valkey/blob/717ec1e1440d94ef1ebe064addaffc4970d88c29/src/module.c#L11514, even though we attempted to remove it. Was this a miss @PingXie, or is there some reason we have to keep it?

Apr 07 '24 07:04 madolson

Can i pick up this issue ? @madolson I have a question, "we attempted to remove it" -> did you mean rename it or move it to another Module ? p/s: ValkeyModuleEvent_MasterLinkChange event is used by ValkeyModuleEvent module.

Apr 08 '24 04:04 9bany

@0del Go for it

Apr 08 '24 15:04 madolson