valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Compile with fast_float by default

Open zuiderkwast opened this issue 4 months ago • 4 comments

Changes the Makefile to compile with USE_FAST_FLOAT=yes by default.

When fast_float was added in a minor version, we didn't want to compile with it by default, but we can change that in the upcoming major version 9.0.

zuiderkwast avatar Aug 07 '25 09:08 zuiderkwast

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 71.57%. Comparing base (fd8270a) to head (e3d8ae3). :warning: Report is 5 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2448      +/-   ##
============================================
+ Coverage     71.54%   71.57%   +0.03%     
============================================
  Files           125      125              
  Lines         69214    69215       +1     
============================================
+ Hits          49522    49544      +22     
+ Misses        19692    19671      -21     

see 13 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 07 '25 09:08 codecov[bot]

:sleepy: I forgot that I already tried this before in #2295 and it needs some changes to some environments.....

zuiderkwast avatar Aug 07 '25 14:08 zuiderkwast

@roshkhatri Do we compile this by default for the container?

madolson avatar Nov 10 '25 16:11 madolson

Yes we do compile containers with fast float by default.

roshkhatri avatar Nov 10 '25 17:11 roshkhatri