valkey
valkey copied to clipboard
Accept socket judge fd overflow
when we use sentinel manage a large cluster, the fd may overflow; then the clients that cfd greater than the aeEvent size, lead to these clients leak.
Because in createCleint(), we don`t check connSetReadHandler() return values.
Codecov Report
Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
Project coverage is 71.50%. Comparing base (
d6507f3) to head (c592be9).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/socket.c | 25.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## unstable #2255 +/- ##
============================================
+ Coverage 71.47% 71.50% +0.03%
============================================
Files 123 123
Lines 66903 66907 +4
============================================
+ Hits 47816 47841 +25
+ Misses 19087 19066 -21
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/socket.c | 91.16% <25.00%> (-0.37%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
like this sentinel client list, our sentinel set maxclients 10000, but there are some clients fd more than 10000.
good catch!