valkey icon indicating copy to clipboard operation
valkey copied to clipboard

code cleanup: move printver.tcl into info-command.tcl

Open daniel-house opened this issue 1 year ago • 1 comments

It seems that https://github.com/valkey-io/valkey/blob/unstable/tests/unit/printver.tcl should be absorbed into https://github.com/valkey-io/valkey/blob/unstable/tests/unit/info-command.tcl

It was created 13 years ago by antirez. Based on the comment

Print version info before running the test

it was created as a development test tool just for the two info-fields redis_version and redis_git_sha1 (which is now server_git_sha1). All it does is check that the fields are present and print their values.

redis_version is already checked in info-command.tcl. redis_git_sha1 and some other fields should be added to info-command.tcl.

daniel-house avatar Apr 04 '24 20:04 daniel-house

yean, i think we can remove it, it is indeed should be cover by the info-command.tcl

enjoy-binbin avatar Apr 05 '24 11:04 enjoy-binbin