valkey icon indicating copy to clipboard operation
valkey copied to clipboard

OpenSSF scorecard + openSSF best practice.

Open AugustinMauroy opened this issue 1 year ago • 9 comments

OpenSSF scorecard is a super tools done by the OpenSSF to give a security score of an repo.

Best practice is giving a tier for the accomplished good open source practice of the project.

AugustinMauroy avatar Apr 04 '24 17:04 AugustinMauroy

Seems a bit low priority, given what it provides us and we don't have a lot of dependencies.

madolson avatar Apr 04 '24 17:04 madolson

Seems a bit low priority, given what it provides us and we don't have a lot of dependencies.

I think you misunderstood what is openSSF scorecard. It's not a dependency analyser, it's a project analyser like codeQL. It's take a look if someone push commit directly on main, if there a ci, if releases is signed ...

AugustinMauroy avatar Apr 04 '24 18:04 AugustinMauroy

Ok, I'll take a look at adding it then and see if we find it useful.

madolson avatar Apr 04 '24 18:04 madolson

@bjosv Is this what you did in some other projects?

zuiderkwast avatar Apr 04 '24 20:04 zuiderkwast

Yes, I'm currently looking into OpenSSFs suggestions and I see there are good suggestions that we easily can fix in valkeys CI workflows. I can fix those in a PR, but then there are other improvement like branch-protection that you maintainers need to config in the project settings.

bjosv avatar Apr 05 '24 10:04 bjosv

I ran OpenSSFs tool on the project and the current scorecard is not bad: Aggregate score: 7.0 / 10 but it will be improved by the fixes.

bjosv avatar Apr 05 '24 10:04 bjosv

I ran OpenSSFs tool on the project and the current scorecard is not bad: Aggregate score: 7.0 / 10 but it will be improved by the fixes.

there are a GitHub action to automatically get score.

AugustinMauroy avatar Apr 05 '24 11:04 AugustinMauroy