valkey icon indicating copy to clipboard operation
valkey copied to clipboard

[NEW] Adding merge queue to unstable branch

Open roshkhatri opened this issue 7 months ago • 4 comments

The problem/use-case that the feature addresses

This would be helpful to catch test failures that happen in daily tests before they get to the unstable branch for complex as well as simple merges

Description of the feature

We can enable on the merge queue on github for a specific timeouts. We would also have to decide the tests that we would need to run on these commits.

Additional information

How merge queues work : As pull requests are added to the merge queue, the merge queue ensures that they are merged in a first-in-first-out order where the required checks are always satisfied.

roshkhatri avatar May 14 '25 18:05 roshkhatri

@roshkhatri can we include scenarios like what happens if one of the commits fail in the merge queue? Will we have retries?

sarthakaggarwal97 avatar May 14 '25 22:05 sarthakaggarwal97

is this feature? https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue

hwware avatar Oct 20 '25 13:10 hwware

Yes thats the feature

roshkhatri avatar Oct 20 '25 13:10 roshkhatri

We'll try it, if it works well we can keep it. Otherwise we'll revert it.

Note from the weekly sync with the maintainers

roshkhatri avatar Oct 20 '25 21:10 roshkhatri