valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Rename: forking deps/hiredis

Open 9bany opened this issue 10 months ago • 4 comments

There is no decision about this yet.

It is used by valkey-cli and valkey-benchmark.

As long as hiredis is vendored, we shall probably avoid changing anything in it, since it would make our vendored version diverge from the upstream hiredis. We can consider forking it though.

9bany avatar Apr 04 '24 00:04 9bany

i can't assign this issue to myself, please help me @zuiderkwast

9bany avatar Apr 04 '24 15:04 9bany

There is no decision about this yet, so please hold off. Maybe we'll do it in a future release I would say. There are some drawbacks, like being unable to update it if if hiredis is improved upstream. It's still BSD.

zuiderkwast avatar Apr 04 '24 15:04 zuiderkwast

i see, let me know and then we can update, i will be happy to help.

9bany avatar Apr 04 '24 15:04 9bany

@michael-grunder

zuiderkwast avatar Apr 04 '24 17:04 zuiderkwast