valkey
valkey copied to clipboard
Replace all "redis" keywords to "valkey" in tcl test files
In test tcl files, a lot of "redis" keywords represent server,for example
spawn_instance redis $::redis_base_port $::instances_count {
"enable-protected-configs yes"
"enable-debug-command yes"
"save ''"
}
We would like to use other words to replace the "redis"
Note: 1.Do not touch the words such as "redis_version" because in the info command, we will still keep these output 2. Do not change any RedisModule* words becuase we still want to keep it.
The word server seems much to dangerous to me. As we discussed off-line, there is at least one place where that word is already in use as the name of something. Please see https://github.com/valkey-io/valkey/blob/c0a83c00583ed2959079ae34ed8ca4cf7f90a264/tests/support/redis.tcl#L60
It is actually a client in most cases. :) Maybe it's safer to replace it with valkey... Or we can also leave it as "redis".
I'd vote just replace redis with valkey in the tests.
@hwware you're assigned to this issue so i'll let you decide about #287. It seems to be overlapping a bit with you pr #283.
@hwware Is this still needed?
I think I can close this. Thanks for ping me.
OK, but we have still many occurrences of "redis" in TCL test files. Many of them are Lua code like return redis.call('get','x') where we could replace redis.call with server.call.