valkey-py icon indicating copy to clipboard operation
valkey-py copied to clipboard

RFC: `sismember` to return bool

Open mkmkme opened this issue 1 month ago • 1 comments

At this moment, sismember returns an integer representing whether a value is a member of the set:

>>> v.smembers(56)
['0', '1', '2', '3', '4', '5', '6', '7', '8', '9']
>>> v.sismember(56, 1)
1
>>> v.sismember(56, 999)
0

Similarly, smismember returns a list of literals instead of bools:

>>> v.smismember(56, range(11), 9)
[1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 1]

I have a question to valkey-py users: would you benefit if these functions returned bool instead? So that True would be returned instead of 1 and False instead of 0.

I invite every valkey-py user of these functions to chime in.

mkmkme avatar Nov 08 '25 14:11 mkmkme