valkey-bloom icon indicating copy to clipboard operation
valkey-bloom copied to clipboard

Valkey-bloom doesn't provide command info

Open madolson opened this issue 5 months ago • 4 comments

There is a module API, SetCommandInfo, which allows clients to provide argument information so that it auto-completes in some tooling like the CLI. E.X.

Image

vs

Image

madolson avatar Jul 30 '25 04:07 madolson

Hi, I’d like to pick up this issue and implement the SetCommandInfo support for the module API. Could you assign me? Thanks!

bravo1goingdark avatar Nov 20 '25 23:11 bravo1goingdark

Hey, valkey-bloom uses the valkeymodule-rs crate and this uses the SetCommandInfo API already in the macro for command creation. Rather than implementing SetCommandInfo, if you are interested in adding the auto complete support, you can look into this and add the KeySpec definition for the commands.

Thanks :D

KarthikSubbarao avatar Nov 21 '25 17:11 KarthikSubbarao

will work on it

bravo1goingdark avatar Nov 23 '25 00:11 bravo1goingdark

Hi! PR #78 implements full KeySpec support for all BF.* commands.
COMMAND INFO now shows the correct key metadata.

Argument metadata (args:) is not included because the current valkeymodule-rs version does not support it yet.

A review would be appreciated!

bravo1goingdark avatar Nov 23 '25 08:11 bravo1goingdark