ExplorerPatcher icon indicating copy to clipboard operation
ExplorerPatcher copied to clipboard

Fix Weather ep_weather_provider_google_script: use classname to get image ID that is now dynamic

Open davids5 opened this issue 6 months ago • 3 comments

Fixes Weather widget is broken (#1334)

Here is the release build

ep_weather_host.zip

davids5 avatar Jun 20 '25 09:06 davids5

This new DLL worked flawless. Not even need to clear widget local data but to make sure it was working I did clear and like I said...it's working. Tks a lot for pointing out the solution. No Explorer or Computer restart was needed.

Galthariel avatar Jun 20 '25 18:06 Galthariel

Ditto for me. this new DLL worked. I did clear the widget local data and I restarted ExplorerPatcher but did not restart my computer.

mmalloy0 avatar Jun 21 '25 00:06 mmalloy0

Because these values are dynamically generated by google, I don't think this change will work in the long run. Please correct me if I'm wrong though.

pyrates999 avatar Jun 21 '25 01:06 pyrates999

@valinet Can this come in?

davids5 avatar Jul 09 '25 16:07 davids5

Sorted and working...

For those unsure like I was...

Disable weather and wait a few seconds.

Then replace the current dll in "c:\Program Files\ExplorerPatcher" and re-enable weather.

DeanosT50 avatar Jul 13 '25 07:07 DeanosT50

Fixes Weather widget is broken (#1334)

Here is the release build

ep_weather_host.zip

hey this works great, thanks

TaylorFan01313 avatar Jul 27 '25 01:07 TaylorFan01313

This new ep_weather_host.dll library worked flawlessly. There was no need to even clear the widget's local data, just to make sure it worked. There was no need to restart Explorer or the computer. Thanks a lot for pointing out the solution to davids5.

Wozmar avatar Jul 27 '25 02:07 Wozmar

If it works for you, it means the class name that has the weather data is YQ4gaf zr758c. If it isn't working for you, it means the class name YQ4gaf zr758c does not exist.

pyrates999 avatar Jul 27 '25 08:07 pyrates999

Fixes Weather widget is broken (#1334)

Here is the release build

ep_weather_host.zip

Thank you so much, weather widget is working fine now.

mikal-s avatar Aug 17 '25 16:08 mikal-s

Thanks. Weather widget is now working.

bitaljus avatar Aug 18 '25 11:08 bitaljus

Just an FYI... If you needed any more proof that this is a Google weather issue, note that today the graphics are different than they were yesterday and there is no graphic in the task bar - only a temp. The .dll works like charm in getting the widget to display, but it's up to Google to make it look like it should. And the last I checked, the Sun is round, not lumpy 😂

cjahn50 avatar Sep 01 '25 19:09 cjahn50

Today, regardless of the icon settings, the display is as shown in the attachment. The weather icon has disappeared from the taskbar, as mentioned above. Inside the widget, there is again a gap (this has happened before and was resolved with an update), and all the information is shifted down.

Screenshot 2025-09-01 231332

dissonator avatar Sep 01 '25 20:09 dissonator

Today, regardless of the icon settings, the display is as shown in the attachment. The weather icon has disappeared from the taskbar, as mentioned above. Inside the widget, there is again a gap (this has happened before and was resolved with an update), and all the information is shifted down.

Screenshot 2025-09-01 231332

Yep, that's what it looks like. Lumpy suns and all. 😂

cjahn50 avatar Sep 01 '25 22:09 cjahn50

Looking at the source of the data https://www.google.com/search?q=weather it is what changed. There is a mapping in the EP weather dll to the icon set that will need to be revisited.

Because the lumpy sun and other graphics may not survive in the eye of public opinion, am of the mindset of waiting before changing the dll.

davids5 avatar Sep 02 '25 10:09 davids5

Everything's working with the new dll, except, as stated above, only temperature is displayed and not the icon beside it. Changing the settings to display text next to the temperature works, but I don't want text (it's way too long to fit), but the icon.

I hope there will be a fix soon.

lucvw1975 avatar Sep 02 '25 11:09 lucvw1975

Looking at the source of the data https://www.google.com/search?q=weather it is what changed. There is a mapping in the EP weather dll to the icon set that will need to be revisited.

Because the lumpy sun and other graphics may not survive in the eye of public opinion, am of the mindset of waiting before changing the dll.

I would not change anything. This is clearly a Google 'design' choice. With your current .dll, the widget loads as it should and is stable. And, I agree with you, the life span of a lumpy sun is probably pretty short. 😂

cjahn50 avatar Sep 02 '25 16:09 cjahn50

Because the lumpy sun and other graphics may not survive in the eye of public opinion, am of the mindset of waiting before changing the dll.

I would like to emphasize once again that the Microsoft icon pack is not applied through the ExplorerPatcher/Weather/Icon pack settings. And of course, the absence of the weather icon in the tray is disappointing https://github.com/valinet/ExplorerPatcher/issues/4545#issue-3376026859

dissonator avatar Sep 03 '25 22:09 dissonator

Hi @davids5, I want to make a new release soon (before Tuesday) to fix a breaking bug with taskbar toolbars on latest 24H2 optional update and onwards. I'd say it's better to be consistent with Google by adding the lumpy sun rather than leaving the icon blank...

Amrsatrio avatar Sep 05 '25 20:09 Amrsatrio

@davids5 @Amrsatrio Today everything stopped working after "Clear weather widget local data." Numerous different tricks and nothing helped to restore at least what was there. As mentioned earlier, "Unable to load weather information." It seems the widget can be buried...

dissonator avatar Sep 11 '25 17:09 dissonator

@davids5 @Amrsatrio Today everything stopped working after "Clear weather widget local data." Numerous different tricks and nothing helped to restore at least what was there. As mentioned earlier, "Unable to load weather information." It seems the widget can be buried...

Working 100% for me! Even the wobbly sun came back in the taskbar widget after the last Windows update on Wednesday...

DeanosT50 avatar Sep 12 '25 05:09 DeanosT50

Working 100% for me!

It worked for me today too. The strip at the top of the widget has disappeared. The taskbar icon still does not display. It seems that Google has nothing to do at all.

dissonator avatar Sep 12 '25 09:09 dissonator

image

Many restarts the past few days.

I recon if you having issues, check for windows updates and see after than.

All worked after Wednesday for me, no problems....

DeanosT50 avatar Sep 12 '25 09:09 DeanosT50

check for windows updates

This is not related at all (it's hard to even imagine a more pointless piece of advice). There were no updates related to the People app. There is no icon in the taskbar for anyone on my contact list.

Does anyone else besides DeanosT50 see the icon in the taskbar?

dissonator avatar Sep 12 '25 09:09 dissonator

All I'm saying is that after the update, it all worked perfect again.

Just my observation. Sorry if 6ou think my advise is stupid and pointless but it is what it is!

Even the comment right above mine says it also working after that.

Maybe your mach9ine has issues, or just you...

DeanosT50 avatar Sep 12 '25 10:09 DeanosT50

image

No icon on my end. Fresh compile. And I agree with @dissonator, Windows updates have nothing to do with EP's custom weather widget + custom taskbar.

I'll get this checked throughout this weekend.

Amrsatrio avatar Sep 12 '25 10:09 Amrsatrio

It doesn't work.

image

iG8R avatar Sep 12 '25 10:09 iG8R

Not sure what you all mean by fresh compile, but I haven't changed a thing, just that last windows update.

Sorry I can't help any further.

DeanosT50 avatar Sep 12 '25 10:09 DeanosT50

Right now I did "Clear weather widget local data" and again "Unable to load weather information" ))) I will try to restart the work computer lol...

dissonator avatar Sep 12 '25 10:09 dissonator

By fresh compile I mean I have the latest EP code running.

Amrsatrio avatar Sep 12 '25 10:09 Amrsatrio

@dissonator I hit Reload in the popup and everything but the taskbar button icon comes up.

Amrsatrio avatar Sep 12 '25 10:09 Amrsatrio