24h2 network system icon can't trigger control center

[jw0785]

set Network: Control Center doesn't work. however, gear icon does.

[Panzimy]

As said 24H2 is not fully supported and isn't recommended

[Panzimy]

And do you used this?

[jw0785]

well that one works. control center doesn't

[Amrsatrio]

I'll have this considered for the next update. Thanks for the report.

[michkot]

Confirmed for me too. OS 26100.4562 patcher v. 68.2

Setting System Tray: Network to Control Center leads to it doing nothing. Windows 11 and Windows 10 flyout work. Also, setting Battery to Windows 10 leads to the button doing nothing. (Sound to Windows 10 flyout works).

[pyrates999]

Confirmed for me too. OS 26100.4562 patcher v. 68.2

Setting System Tray: Network to Control Center leads to it doing nothing. Windows 11 and Windows 10 flyout work. Also, setting Battery to Windows 10 leads to the button doing nothing. (Sound to Windows 10 flyout works).

https://github.com/valinet/ExplorerPatcher/wiki/Frequently-asked-questions#the-windows-10-battery-flyout-does-not-open

[m-wigley]

I looked into this for a while but couldn't fix the control center not opening issue. ImmersiveFlyouts.c:

            hr = WindowsCreateStringReference(
                L"Windows.Internal.ShellExperience.ControlCenter",
                (UINT32)(sizeof(L"Windows.Internal.ShellExperience.ControlCenter") / sizeof(wchar_t) - 1),
                &hstringHeader,
                &hstring
            );
            if (hstring)
            {
                IUnknown* pIntf = NULL;
                pShellExperienceManagerFactory->lpVtbl->GetExperienceManager(
                    pShellExperienceManagerFactory,
                    hstring,
                    &pIntf
                );
                // pIntf is null
                if (pIntf)
                {

pShellExperienceManagerFactory->lpVtbl->GetExperienceManager(

is returning null. The "Windows.Internal.ShellExperience.ControlCenter" string is still in twinui.dll. I also notice ShellExperienceHost.exe is now renamed to ShellHost.exe, which may be relevant.

[pyrates999]

Windows 8 Flyout still works on windows 10, so you can't remove that option. Or only remove it for windows 11 24h2.

You need to test your changes on windows 10.

[m-wigley]

Windows 8 Flyout still works on windows 10, so you can't remove that option. Or only remove it for windows 11 24h2.

You need to test your changes on windows 10.

I assume you're referring to: https://github.com/valinet/ExplorerPatcher/pull/4478/files will my new check:

inline BOOL IsWindows11Build25346OrHigher()
{
    if (!global_rovi.dwMajorVersion) global_ubr = VnGetOSVersionAndUBR(&global_rovi);
    return global_rovi.dwBuildNumber >= 25346;
}

not be sufficient? It's structured the same way as the other IsWindows11* checks. Please comment on the PR, not here by the way since this is a different issue.

[pyrates999]

Ok, that looks fine to me :)