ExplorerPatcher
ExplorerPatcher copied to clipboard
valinet
Update ep_gui.en-US.rc
Good morning
I have been using ExplorerPatcher for more than two years on a small fleet of PCs and I know how it works quite well. First of all, I would like to thank you for the excellent work done which allowed me to regain control of the management of my various PCs. I have been working almost from the beginning on translating the software into French and I did it via the settings.reg and settings10.reg files locally on my PCs to create my .dlls derived from the official .dlls. I have just noticed with joy that the software is finally available in a multilingual version and therefore I wanted to make my contribution both for the French version and for the native English version because the purpose of the open source software is good to be able to share points of view. I added a few capital letters or plurals as well as a few hyphens just to catch the eye. I added a few words such as "simplified" or "Win_Key" or "(S_W_S)" or "switcher" or "proportion" or even "ExplorerPatcher" for the same reasons. As for the expression "Remember the last used section in this window" I propose this version "Open ExplorerPatcher on the tab of the last used section" which is far from your version but which has the advantage of being better understood by users ordinary people who discover the software. The same goes for the three texts on the choice of update notifications.
Do not hesitate to give me your feedback on my proposal because I remain open and it is by confronting divergences that we can address relevance.
Very sincerely Dennis
PS: Finally, I would like to make a proposal for interactive active display of the options in the Windows Switcher tab and in the Weather tab but this action involves modifying the Settings.reg and Settings10.reg files and it will therefore be subject to of a next pull request.
I have updated my proposal taking into account your comments. Thanks again for the work and have fun.
Do I have anything to do to validate or do I just have to wait? Greetings
I approved because it looks LGTM although a collaborator has to give the final say on this one.
I suggest this change:
For IDS_UPDATES_POLICY_0, it should be set to "Notify in all cases for update checking, whether an update is available or not"
I propose finally this version : Notify in all cases for updates checking, whether the result is positive or not !
For me there is no more change to do at this time
I propose finally this version : Notify in all cases for updates checking, whether the result is positive or not !
For me there is no more change to do at this time
That makes me have to re-read it when you phrase it like that. I prefer my suggestion as it is more clear.
I propose finally this version : Notify in all cases for updates checking, whether the result is positive or not ! For me there is no more change to do at this time
That makes me have to re-read it when you phrase it like that. I prefer my suggestion as it is more clear.
Hi I gave you a response regarding the plural wording and you didn't seem to respond to it. I am not obstinate by nature and if you wish to validate the text of your proposal I see no problem. Do I have something else to do for validation (modify the text with your proposal for example?) or are you the only one who can validate the proposal to update the text?
Very sincerely Dennis
I propose finally this version : Notify in all cases for updates checking, whether the result is positive or not ! For me there is no more change to do at this time
That makes me have to re-read it when you phrase it like that. I prefer my suggestion as it is more clear.
Hi I gave you a response regarding the plural wording and you didn't seem to respond to it. I am not obstinate by nature and if you wish to validate the text of your proposal I see no problem. Do I have something else to do for validation (modify the text with your proposal for example?) or are you the only one who can validate the proposal to update the text?
Very sincerely Dennis
Sorry, I noticed that you made update plural instead of singular. It should be this:
Notify in all cases for update checking, whether an update is available or not
You put it as:
Notify in all cases for updates checking, whether updates are available or not
There is not multiple updates here, only one update being checked for. Therefore the word update should be used instead of updates.
I saw your changes. You had it right with this commit: https://github.com/valinet/ExplorerPatcher/pull/2657/commits/e34774945a1a6fbfcabdeb66f9e5704b237aef26
You then changed it with the next commit, which I cannot understand why.
Hi, this answer might be lame but, I'm sorry that if the English texts change, that means the translated texts have to change too.
It should make sense for each language. It doesn't have to be a direct translation for each language.
Good morning I read and understand that indeed a change to the reference text in English implies that each language is subsequently updated.
This is why I agree with the decision to close this pull request with however a regret that even if the English text is the reference it is nonetheless subject to the rule of good understanding by all users. (so that the use of the software is as simple and efficient as possible).
Despite everything, I am delighted to have been able to participate in a debate on this issue and remain invested in my contribution to the development of ExplorerPatcher
Very sincerely Dennis
This is not changing the meaning of the feature. It is making the English version easier to understand. Other languages do not need to change when you improve the meaning in one language.