validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

chore: update to eslint 8

Open WikiRik opened this issue 9 months ago • 1 comments

This PR updates the eslint version to 8, only running on Node 22 in CI. I've moved all eslint-disables to the end of the line and I have enabled some rules that we've previously enabled but were easy/automated to fix.

One rule that caused issues which was easy to fix is the no-restricted-globals. This caused some tests in isDate and isIn to fail, which we'll need to debug later.

I did not update to eslint 9, or the flat config, yet because the airbnb-base config doesn't fully support that yet.

Checklist

  • [X] PR contains only changes related; no stray files, etc.
  • [X] README updated (where applicable)
  • [X] Tests written (where applicable)
  • [X] References provided in PR (where applicable)

WikiRik avatar Apr 09 '25 16:04 WikiRik

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (bdb8f9e) to head (2bd587f).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2552   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2535      2534    -1     
  Branches       641       641           
=========================================
- Hits          2535      2534    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 09 '25 16:04 codecov[bot]