validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

Should isURL accept accented urls or should make this validation optional?

Open toofff opened this issue 1 year ago • 1 comments

Describe the bug The following url are valid: https://my-ùrl.com & https://my-url.coù

Should accented URLs be allowed?

Shouldn't we add an option to invalidate URLs with accents if the option is enabled?

Thank you for your feedback

Additional context Validator.js version: 13.11.0 Node.js version: 20.11.0 OS platform: windows, linux & macOS

toofff avatar Jun 18 '24 20:06 toofff

If there's a development to be made for this pull request, I'm willing to take care of it. I'd just like to know in which direction you want to go with this?

Is this a bug for you? Or could we create an option not to accept accented urls?

I discovered this problem because my API uses Apache's UrlValidator Java class and accented urls are not accepted.

toofff avatar Jun 21 '24 14:06 toofff