validatorjs
🚧: Stale Prs
I think its time to merge/close Prs that have been stale for too long . Most of them have merge conflicts which are restricting them from being merged while some have some small changes to be made. Lets use this issue to report, and if needed reassign and merge them. Anyone upto the challenge , feel free to drop in the issue before you get started :)
Please find the list below: https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+review%3Achanges-requested+sort%3Acreated-asc https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land+sort%3Acreated-asc
A starting measure to find stale prs is to find prs with change requested status over 1+ years of no response from author
Also good ones are mc-to-land, meaning they were already reviewed and just waiting for the merge-conflict fix. But I see that they are now few, so it's better to focus on the change requested ones that you shared.
@profnandaa Can I start working on this? https://github.com/validatorjs/validator.js/issues/2328
@rubiin I'm sorry if I sound dumb, but how would we contribute to the same PR and resolve conflicts if they were raised from other people's fork? Are we supposed to create our own fork and copy the changes from the Original PR?
Yeah . Create your own fork, commit the changes done by the original author and resolve the merge conflicts in your own fork.
Yeah . Create your own fork, commit the changes done by the original author and resolve the merge conflicts in your own fork.
Understood. Thanks for clarifying
Hi, @rubiin , I have fix this PR https://github.com/validatorjs/validator.js/pull/2062, Here is my PR https://github.com/validatorjs/validator.js/pull/2475
Please, have a look.
