feat(types): add types file
This PR adds types file within the repo itself . The types file is derived from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/validator with some modifications
Checklist
- [x] PR contains only changes related; no stray files, etc.
- [ ] README updated (where applicable)
- [ ] Tests written (where applicable)
- [x] References provided in PR (where applicable)
Having types file here will make sure the types and codebase are in sync.
LGTM. Could you please also add some guidelines on how to use, on the README? Perhaps adding a section for Types?
Sure thing. I will update the readme for this
Since the types get installed along with the library, there is no need to install @types/validator package anymore for typescript support. I have added a small section on readme for that but we should also point this on the realease notes @profnandaa
Having types file here will make sure the types and codebase are in sync.
+1 for this one, I've been checking the latest @types/validator version doesn't include the type for isAbaRouting. It seems this PR is outdated because this type is missing here too.
Yeah . Since we have types file here , we dont have to depend on the @types/ packages . They can be slow and outdated so self managing is a better option
For now we can ship this and on later date , break it down on smaller files.