validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

#2370 readme.md toBoolean function documentation typo - solved , Update README.md

Open Anayverma opened this issue 1 year ago • 1 comments

Checklist

  • [ ] PR contains only changes related; no stray files, etc.
  • [ ] README updated (where applicable)
  • [ ] Tests written (where applicable)
  • [ ] References provided in PR (where applicable)

Anayverma avatar Feb 11 '24 17:02 Anayverma

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b958bd7) 99.95% compared to head (c68262f) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2373      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 11 '24 17:02 codecov[bot]

As mentioned in #2374; let's come to a conclusion on the wanted text in #2370 first.

The first sentence of your suggestion is not consistent with the first sentences of the other validators

WikiRik avatar Mar 06 '24 12:03 WikiRik

could you provide me any suggestions ?

Anayverma avatar Mar 07 '24 09:03 Anayverma

As #2370 has been closed because the consensus is that we already use the correct text, I'm closing this PR as well

WikiRik avatar May 07 '24 20:05 WikiRik