validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

Published 20 hours ago • verified publisher icon validatorjs

readme.md toBoolean function documentation typo

Open krishnenduroy52 opened this issue 1 year ago • 2 comments

Describe the bug In the sanitization section for the toBoolean function in documentation/readme, the expected behavior is for '0', 'false', and '' to return false, but currently in readme.md file, it saying true.

Examples image

krishnenduroy52 avatar Feb 01 '24 06:02 krishnenduroy52

"Everything expect for ... return true." I think that's correct

WikiRik avatar Feb 01 '24 07:02 WikiRik

I think there's an issue of reframing. I am interested in working on this issue. @krishnenduroy52 please assign it to me.

Anayverma avatar Feb 11 '24 17:02 Anayverma

Looks correct to me as well, see comment above by WikiRik. I would tend to want to close this, if there are no strong feelings about this, ony why this NEEDS to be changed.

Will set myself a reminder for a week and then come back to close, if I don't hear anything back.

pano9000 avatar Mar 05 '24 16:03 pano9000

This looks correct IMO. Others agree as well. Closing this for now

rubiin avatar Mar 27 '24 14:03 rubiin