validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

feat: :safety_vest: add support for Dominican Republic passport numbers

Open Victor1890 opened this issue 1 year ago • 5 comments

Hey! Would it be possible to support Dominican Republic Passport Valid Number type from validation? Thanks

Checklist

  • [x] PR contains only changes related; no stray files, etc.
  • [x] README updated (where applicable)
  • [x] Tests written (where applicable)
  • [ ] References provided in PR (where applicable)

Victor1890 avatar Jan 29 '24 01:01 Victor1890

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.95%. Comparing base (b958bd7) to head (b23d237). Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2366      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 29 '24 01:01 codecov[bot]

@profnandaa Codecov is fixed in https://github.com/validatorjs/validator.js/pull/2341

WikiRik avatar Mar 05 '24 13:03 WikiRik

@WikiRik I was use ChatGPT for valid the info and looking for the passport to few people, I have to come the conclusion to passport number have 2 letter (RD) and it have 7 digital number

This is the link: https://chat.openai.com/share/8f1b1bfd-1cdf-4d96-bda0-0ed27f7bf276

Victor1890 avatar Mar 11 '24 14:03 Victor1890

ChatGPT is not a valid source for this repository.

WikiRik avatar Mar 11 '24 17:03 WikiRik

Hi @WikiRik, thank you for your waiting.

The element that refers to the unique numbering on the passport document is the Document Number (Número de documento) which uniquely identifies a document and is recommended to be identical to the Control Number (Número de control) assigned at the time of manufacture for registration and security purposes.

You can check the information in this link: https://www.icao.int/publications/Documents/9303_p1_cons_es.pdf

Victor1890 avatar Apr 30 '24 19:04 Victor1890