validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

FEAT: Added the mobile number validator for MARSHALL ISLANDS

Open poswalsameer opened this issue 1 year ago • 5 comments

This PR adds the country code with the regex mobile number validator for the country MARSHALL ISLANDS.

Fixes #1761

New country added at Line 125

Screenshot (193)

poswalsameer avatar Jan 28 '24 16:01 poswalsameer

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b958bd7) 99.95% compared to head (dcfbe14) 99.95%.

:exclamation: Current head dcfbe14 differs from pull request most recent head 7a0688d. Consider uploading reports for the commit 7a0688d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 28 '24 16:01 codecov[bot]

hello @ezkemboi sir, this is my first time contributing to any project. I have added the Marshall Islands to the list and created a PR. I have passed all test but need 2 reviews before merging of this pull request.

poswalsameer avatar Jan 28 '24 16:01 poswalsameer

Please add tests. Also, it seems, there are more to do, update the readme.

ezkemboi avatar Jan 28 '24 17:01 ezkemboi

@poswalsameer can you check on the changes I made on this PR while back #1558 Can give you ideas of items you need to add. Thanks for the PR

ezkemboi avatar Jan 28 '24 17:01 ezkemboi

@poswalsameer can you check on the changes I made on this PR while back #1558 Can give you ideas of items you need to add. Thanks for the PR

sure sir, will check that!

poswalsameer avatar Jan 29 '24 15:01 poswalsameer