validator.js
validator.js copied to clipboard
Modified symbolRegex in isStrongPassword to include '\'
isStrongPassword - Bug fix
I modified the special character regex a little bit to add validation for '\' character. I worked on this based on an issue in the repository
Checklist
- [x] PR contains only changes related; no stray files, etc.
- [ ] README updated (where applicable)
- [x] Tests written (where applicable)
- [ ] References provided in PR (where applicable)
Codecov Report
Patch coverage: 100.00%
and no project coverage change.
Comparison is base (
b958bd7
) 99.95% compared to head (8c06778
) 99.95%.
Additional details and impacted files
@@ Coverage Diff @@
## master #2278 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 107 107
Lines 2454 2454
Branches 619 619
=======================================
Hits 2453 2453
Partials 1 1
Files Changed | Coverage Δ | |
---|---|---|
src/lib/isStrongPassword.js | 100.00% <100.00%> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the PR! Don't forget to add additional tests before we can review this