maintenance: post 2308 release

[profnandaa]

This is a B release, post the main last major one #2252 , mainly to fix the regression in isDate but escorted with a few more "feature patches".

13.11.3

Follow up release to fix the regression in isDate

Fixes and New Locales

• #2257 isDate timezone offset fix @tomaspanek
• #2265 isPassportNumber added ZA validator @GMorris-professional
• #2267 isMobilePhone added en-MW validator @SimranSiddiqui

[profnandaa]

Sorry I'll delay the release to Monday. I'm also struggling having clean builds but has nothing to do with the new changes.

[rubiin]

@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped

[profnandaa]

@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped

@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?

[rubiin]

@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped

@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?

I think most of it can be borrowed and added upon from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/validator We might have to add a info on post install to let users know to prefer our types over types in DefinitelyTyped. The first version can be a simple copy paste.

[WikiRik]

@profnandaa any chance we can get this release out soon?

[profnandaa]

@WikiRik - struggled with getting a clean build last time and stalled. I need some help on that. Was building on latest Node.js stable.

[WikiRik]

What is the issue you got? I'm using Node 18.18.0 in a new GitHub Codespace with the default image and that works fine. You do need to use npm install --legacy-peer-deps, but that's a known issue (see https://github.com/validatorjs/validator.js/issues/2123)

[rubiin]

I have add LGTM labels to few issues, we can add them to this pipeline

[profnandaa]

@WikiRik --

this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/rollup
npm ERR!   dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from [email protected]
npm ERR! node_modules/rollup-plugin-babel
npm ERR!   dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/rollup
npm ERR!   peer rollup@">=0.60.0 <3" from [email protected]
npm ERR!   node_modules/rollup-plugin-babel
npm ERR!     dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy. I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.

Then we work on a follow up release in a month's time.

Thanks for your help in reviewing the PRs and keeping the lights on!

[profnandaa]

Currently reviewing all the LGTMs - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3A%22%E2%9C%85+LGTM%22

[profnandaa]

UPDATE: now pending this mc-to-land s, which I'll do a fix PR for all of them, and then prep the release notes - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land

[rubiin]

Lets try to include more stale prs(mc-to-land) as the number of prs are alot and the number might create a false impression for new contributors as well as users on the libs active status

[rubiin]

@WikiRik --

this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/rollup
npm ERR!   dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from [email protected]
npm ERR! node_modules/rollup-plugin-babel
npm ERR!   dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/rollup
npm ERR!   peer rollup@">=0.60.0 <3" from [email protected]
npm ERR!   node_modules/rollup-plugin-babel
npm ERR!     dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy. I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.

Then we work on a follow up release in a month's time.

Thanks for your help in reviewing the PRs and keeping the lights on!

https://github.com/validatorjs/validator.js/pull/2391 this should fix the problem both on CI and local installs.

[profnandaa]

@rubiin @WikiRik @ezkemboi -- kindly take a look at the release notes (PR description) one last time and I should make the release today evening GMT.

[profnandaa]

13.12.0 now released. Thanks all for the contribution! 🎉 https://www.npmjs.com/package/validator/v/13.12.0 And once again, thanks @WikiRik and @rubiin for your reviews!