validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

feat(isFloat) Fix , passing as float

Open frederike-ramin opened this issue 2 years ago • 1 comments

Similar to #752: Only passing , as string will result in a positive outcome of isFloat. This simply catches the case similar to . and + etc.

Checklist

  • [x] PR contains only changes related; no stray files, etc.
  • [x] README updated (where applicable)
  • [x] Tests written (where applicable)

frederike-ramin avatar Aug 08 '22 09:08 frederike-ramin

Codecov Report

Merging #2020 (8db790f) into master (86a07ba) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2020   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2203      2203           
  Branches       477       477           
=========================================
  Hits          2203      2203           
Impacted Files Coverage Δ
src/lib/isFloat.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 08 '22 09:08 codecov[bot]

@rubiin do I still need to do anything to have this PR merged?

frederike-ramin avatar Oct 04 '22 11:10 frederike-ramin

Waiting for further approvals from @profnandaa

rubiin avatar Oct 17 '22 14:10 rubiin

merging in #2164

profnandaa avatar Feb 02 '23 03:02 profnandaa