validator.js
validator.js copied to clipboard
feat(isFloat) Fix , passing as float
Similar to #752: Only passing ,
as string will result in a positive outcome of isFloat
. This simply catches the case similar to .
and +
etc.
Checklist
- [x] PR contains only changes related; no stray files, etc.
- [x] README updated (where applicable)
- [x] Tests written (where applicable)
Codecov Report
Merging #2020 (8db790f) into master (86a07ba) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #2020 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2203 2203
Branches 477 477
=========================================
Hits 2203 2203
Impacted Files | Coverage Δ | |
---|---|---|
src/lib/isFloat.js | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@rubiin do I still need to do anything to have this PR merged?
Waiting for further approvals from @profnandaa
merging in #2164