validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

Added string to kebab case converter strTokebab() and http query params to object converter queryStrToObject()

Open rezwanahmedsami opened this issue 3 years ago • 4 comments

Added string to kebab case converter strTokebab() and http query params to object converter queryStrToObject()

Checklist

  • [ ] PR contains only changes related; no stray files, etc.
  • [ ] README updated (where applicable)
  • [ ] Tests written (where applicable)

rezwanahmedsami avatar Aug 01 '22 18:08 rezwanahmedsami

Codecov Report

Merging #2013 (4cbf6c2) into master (1bb14e8) will decrease coverage by 0.85%. The diff coverage is 9.52%.

@@             Coverage Diff             @@
##            master    #2013      +/-   ##
===========================================
- Coverage   100.00%   99.14%   -0.86%     
===========================================
  Files          104      106       +2     
  Lines         2203     2224      +21     
  Branches       477      479       +2     
===========================================
+ Hits          2203     2205       +2     
- Misses           0       19      +19     
Impacted Files Coverage Δ
src/lib/queryStrToObject.js 0.00% <0.00%> (ø)
src/lib/strTokebab.js 0.00% <0.00%> (ø)
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1bb14e8...4cbf6c2. Read the comment docs.

codecov[bot] avatar Aug 01 '22 18:08 codecov[bot]

can anyone approve my pull request?

rezwanahmedsami avatar Aug 02 '22 17:08 rezwanahmedsami

I don't think adding a string conversion function falls on the library as we are mostly dealing with validation . Lets hear from @profnandaa on whether we will move forward with this

rubiin avatar Aug 02 '22 17:08 rubiin

yeah sure, but i think it's need to be added, becuase many developers want's this types of function to do it easily. personally i used this types of operation in many projects. So , i don't want to write again and again code for separate projects. Also for others developer they can easily use it if they are using validator js.

Ok waiting to hear from @profnandaa

rezwanahmedsami avatar Aug 03 '22 15:08 rezwanahmedsami