validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

Fix/readme.md

Open ademyan05 opened this issue 3 years ago • 3 comments

fixed the syntax of arrays in the Readme, as some were missing commas and single quotations.

ademyan05 avatar Jun 13 '22 15:06 ademyan05

Codecov Report

Merging #1987 (8b564ae) into master (cfcf911) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1987   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2097      2097           
  Branches       473       473           
=========================================
  Hits          2097      2097           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cfcf911...8b564ae. Read the comment docs.

codecov[bot] avatar Jun 24 '22 18:06 codecov[bot]

@ademyan05 -- can fix the m/c or I can do it in a bulk PR too.

profnandaa avatar Jun 30 '22 03:06 profnandaa

@ademyan05 MR needs fixing

rubiin avatar Jul 27 '22 14:07 rubiin

FYI: I have incorporated the same changes (+ additional fixes) from this PR in my PR as well: https://github.com/validatorjs/validator.js/pull/2107

https://github.com/validatorjs/validator.js/pull/2107/commits/626bcae2a6d5c2c871d43db51f16416fe68c04d0

pano9000 avatar Dec 29 '22 17:12 pano9000

@pano9000 I assume we can close this now #2107 has been merged?

WikiRik avatar Jan 30 '23 19:01 WikiRik

closing the PR as its changes were merged as part of the bigger #2107 / https://github.com/validatorjs/validator.js/commit/0586d230b746102901e2ddebcbd46304190bdf8c @WikiRik thanks for reminding me @ademyan05 thank you for the PR and sorry for having to close this one!

pano9000 avatar Jan 30 '23 20:01 pano9000