validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

Added Egypt, Saudi Arabia, and Tunisia Passport Number Formats RegEx, ran tests, added countries to README.md

Open sherifsallam opened this issue 2 years ago • 5 comments

Changes Made

  • isPassportNumber.js: Added Egypt, Saudi Arabia, and Tunisia Passport Number Format RegEx

  • validators.js: Ran tests for each country

  • README.md: Added each country code

Summary

As requested in issue #1288, I've added three new countries' passport number formats RegEx after extensive research: Egypt, Saudi Arabia, and Tunisia. I've also run tests for all 3 of their RegEx within the file directory and added the country codes to the README.md file.

Checklist

  • [x] PR contains only changes related; no stray files, etc.
  • [x] README updated (where applicable)
  • [X] Tests written (where applicable)

sherifsallam avatar Jun 10 '22 23:06 sherifsallam

Codecov Report

Merging #1982 (6179cc2) into master (cfcf911) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1982   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2097      2097           
  Branches       473       473           
=========================================
  Hits          2097      2097           
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cfcf911...6179cc2. Read the comment docs.

codecov[bot] avatar Jun 10 '22 23:06 codecov[bot]

@rubiin Thank you! Much appreciated. :)

sherifsallam avatar Jun 21 '22 13:06 sherifsallam

looks good

Sorry, I'm new to this. How do we merge after your review? Or do I need an additional review?

sherifsallam avatar Jun 21 '22 13:06 sherifsallam

@sherifsallam Well you dont. Once @profnandaa reviews it, he will merge it

rubiin avatar Jun 22 '22 03:06 rubiin

@sherifsallam please address the changes

rubiin avatar Jul 27 '22 14:07 rubiin