validator.js icon indicating copy to clipboard operation
validator.js copied to clipboard

Mobile Burundi validation

Open pavolmarc opened this issue 2 years ago • 7 comments

Added Burundi phone validation, also edited readme file.

Checklist

  • [X] PR contains only changes related; no stray files, etc.
  • [X] README updated (where applicable)
  • [x] Tests written (where applicable)

pavolmarc avatar Nov 17 '21 10:11 pavolmarc

Codecov Report

Merging #1872 (91f0ed3) into master (f055c11) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1872   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2072      2072           
  Branches       472       472           
=========================================
  Hits          2072      2072           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f055c11...91f0ed3. Read the comment docs.

codecov[bot] avatar Nov 17 '21 10:11 codecov[bot]

@tux-tn Thank you for good points, I added tests and mobile phone specification

pavolmarc avatar Nov 17 '21 21:11 pavolmarc

@tux-tn thank you, so whats the next step? Do i have to merge this or is it done by you or automaticaly?

pavolmarc avatar Nov 18 '21 12:11 pavolmarc

@pavolmarc, the one to merge for now is @profnandaa unless he gives @ezkemboi or @tux-tn a go-ahead.

ezkemboi avatar Dec 19 '21 06:12 ezkemboi

@pavolmarc -- just confirming, should Burundi's locale be rn-BI not en-BI? https://www.localeplanet.com/icu/rn-BI/index.html

profnandaa avatar Feb 17 '22 05:02 profnandaa

If anyone can help clean up this PR, will get it in.

profnandaa avatar Jun 30 '22 02:06 profnandaa

@profnandaa I can do that

rubiin avatar Jul 17 '22 13:07 rubiin