ValheimPlus icon indicating copy to clipboard operation
ValheimPlus copied to clipboard

[BUG] Default value for exploreRadius does not match stock

Open Mar-Veloz opened this issue 2 years ago • 3 comments

  • OS: Windows Client, Linux Server
  • Valheim Game Version: 0.209.10
  • V+ Mod Version: 0.9.9.8

Describe the bug

The default value of exploreRadius (100) is noticeably larger than the stock explore radius. This both means that enabling the map section by default enlarges the explore radius (which seems counter to the opt-in philosophy the mod uses regarding config settings), and also makes it difficult to determine what value I want to set it to (if I want the explore radius to be 50% more than stock, what should I set it to? I don't know, because I don't know what the stock explore radius is).

To Reproduce

  1. Generate a valheim_plus.cfg config file with default values, and set the Map section to enabled.
  2. Observe that you now explore the map at a larger radius than stock.

Mar-Veloz avatar Jul 24 '22 03:07 Mar-Veloz

https://github.com/valheimPlus/ValheimPlus/blob/788420533f5068c2f51be3889a4bfe25d3436f30/ValheimPlus/Configurations/Sections/MapConfiguration.cs#L6

I've only had a cursory look but if this is 50% too much, we should change that 100 to 50?

increddibelly avatar Jul 29 '22 16:07 increddibelly

https://github.com/valheimPlus/ValheimPlus/blob/788420533f5068c2f51be3889a4bfe25d3436f30/ValheimPlus/Configurations/Sections/MapConfiguration.cs#L6

I've only had a cursory look but if this is 50% too much, we should change that 100 to 50?

To be clear, I don't know that it's 50% too much. I was just using that number as an example.

Mar-Veloz avatar Jul 29 '22 19:07 Mar-Veloz

ahh thanks. I don't know yet where to look up the default values. will investigate and correct my PR when I find it

increddibelly avatar Jul 31 '22 12:07 increddibelly