Fix buffer underrun in read_chk_line for empty line

[fmayer]

Also remove redundant condition. We do p = strchr(line, '\n') which looks for the first '\n', so *(p -1) can never be '\n'

[valgur]

Thanks a lot for the fixes! I will review and merge them.

At a higher level, though, I'm not sure how much I'm willing to commit to maintaining the core rnxcmp software that this Python wrapper currently vendors without any real modifications. A much more reliable and sustainable approach in the long term would probably be to add Python bindings for this Rust rewrite instead: https://github.com/georust/rinex

[fmayer]

Thanks a lot for the fixes! I will review and merge them.

At a higher level, though, I'm not sure how much I'm willing to commit to maintaining the core rnxcmp software that this Python wrapper currently vendors without any real modifications. A much more reliable and sustainable approach in the long term would probably be to add Python bindings for this Rust rewrite instead: https://github.com/georust/rinex

Makes sense. Do you happen to know if there is any way to contribute this upstream? I looked a bit but couldn't really find any way to get patches to them.

[valgur]

I have not been on touch with the author, but the only way to reach him is probably over email. I remember him being active on this mailing list: https://lists.igs.org/pipermail/igsmail/2021/008129.html