vue3-popper icon indicating copy to clipboard operation
vue3-popper copied to clipboard

Added 'teleport' prop to allow teleporting popper

Open CatSizeVoyage opened this issue 4 years ago • 11 comments

Using the new teleport functionality to teleport the popper element to the selector specified. In my case I use it to teleport poppers to the bottom of the body, so that they always render above other elements and are not constrained by overflow: hidden parents of trigger elements.

Let me know what you think!

CatSizeVoyage avatar Sep 30 '21 16:09 CatSizeVoyage

Looks like this might need a bit more thought... It causes issues with hovering and interacting if the popper is not a child element.

CatSizeVoyage avatar Sep 30 '21 16:09 CatSizeVoyage

Thanks a lot for putting time into this 👍

Maybe this should be the default behavior instead of messing around with z-index, what do you think?

valgeirb avatar Oct 04 '21 11:10 valgeirb

Potentially yeah. If the teleport prop was defaulted to 'body' then it can always be overridden to return to the inline behaviour. The one downside I've found to teleporting is that it can make it tricky to target the popper element with CSS... which is likely to be a breaking change for some.

CatSizeVoyage avatar Oct 04 '21 14:10 CatSizeVoyage

@CatSizeVoyage dude, there are some conflicts :(

nbrylevv avatar Nov 18 '21 10:11 nbrylevv

Hi, any updates on this one? Or have any decisions been made? Would love to know if there is a change that this PR will make it to a release one day.
Thanks!!!

ruuskju avatar Feb 08 '22 11:02 ruuskju

Hi, any updates on this one? Or have any decisions been made? Would love to know if there is a change that this PR will make it to a release one day.
Thanks!!!

It will, just been pretty busy with life - I'll find the time to focus on this soon 👍

valgeirb avatar Feb 08 '22 12:02 valgeirb

I have resolved the merge conflicts in this fork.

bperel avatar May 20 '22 06:05 bperel

I have resolved the merge conflicts in this fork.

I tried your version and works, but when i click inside of a popover content, it will close. This should close only if i click outside of it.

LE: I ended up by using vue-tippy@v6, whitch works great with Vue 3, and also have the teleport feature by default.

ZsharE avatar Aug 01 '22 13:08 ZsharE