vscode-phpsab icon indicating copy to clipboard operation
vscode-phpsab copied to clipboard

feat(path-resolvers): major rework of path resolution and executable settings

Open valeryan opened this issue 1 year ago • 3 comments

Deprecates the excutablePathCS and excutablePathCBF and creates a cross-platform way to handle paths using Unix-style paths.

TODO: Adding unit test for resolvers

BREAKING CHANGE:

  • Deprecates executablePathCBF in favor of fixerExecutablePath
  • Deprecates executablePathCS in favor of snifferExecutablePath
  • Moves snifferShowSources under the per workspace settings
  • Changes behavior of path resolution and auto search behavior

valeryan avatar Mar 04 '24 06:03 valeryan

I will do my best to review this week.

jonathanbossenger avatar Mar 06 '24 12:03 jonathanbossenger

@valeryan I'm testing this out on my environment now, but I also want to use that test repository you shared at some point. For the life of my I can't find it, would you mind sharing it here again?

jonathanbossenger avatar Mar 10 '24 07:03 jonathanbossenger

@jonathanbossenger https://github.com/valeryan/multi-root-example I need to push an update to it later today (done) but this is my test bed for validating the extension. I feel like we might be able to integrate this at some point for use with an end-to-end test.

valeryan avatar Mar 10 '24 19:03 valeryan

@jonathanbossenger I going to merge this into the dev branch and so we cant start testing that branch heavily at some point.

valeryan avatar Sep 02 '24 20:09 valeryan

Thanks @valeryan

I've not opened VS Code since late June as I've been deep into planning new projects at work, but I should be able to start testing things out again from next week.

jonathanbossenger avatar Sep 04 '24 18:09 jonathanbossenger