Valerio Setti

Results 117 comments of Valerio Setti

Question: new test cases added by @gilles-peskine-arm on his branch check verify not sign. However looking at `pk_wrap.c` it seems to me that also `rsa_sign_wrap()` in the `USE_PSA` case needs...

Note to reviewers: all the commits from #9010 has simply been cherry-picked here.

Force pushed to get all the recent changes in #9010. Once again all the commits were just cherry-picked.

Since #8986 already got some feedback and the CI is almost happy, I started this backport by cherry-picking all the commits from #8986 to the `mbedtls-3.6` branch.

> Please backport to 3.6. This file will move to the framework repository eventually, and in the meantime it's easier if we don't let the branches diverge. Sure, I was...

> I think we should have added the now-generated files to `.gitignore` as well... I can create a quick PR for this. Question: while at this, can I also add...

First of all thanks for the initial review! > * For ECC we know in advance the list of curves, but for RSA what happens if key size is requested...

Quick updates on these points: >> For ECC we know in advance the list of curves, but for RSA what happens if key size is requested for which we don't...

I just created #9010 to track future improvements suggested [above](https://github.com/Mbed-TLS/mbedtls/pull/8986#pullrequestreview-1979455049).

> > Adding a check that the file is up-to-date seems fairly trivial > > Ah actually I see that it relies on having built the programs already, which I'm...