sonic icon indicating copy to clipboard operation
sonic copied to clipboard

Published 20 hours ago • verified publisher icon valeriansaliou

WIP - Async commands

Open perzanko opened this issue 5 years ago • 7 comments

ref: https://github.com/valeriansaliou/sonic/issues/43 In progres...

perzanko avatar May 21 '19 09:05 perzanko

@valeriansaliou I've done some things and almost succeed. There is one thing that is still blocking asynchronous execution, but I have already plan how to solve it. Could you make a code review? Do I go in the right direction?

perzanko avatar May 21 '19 09:05 perzanko

Thanks a ton!! I’ll be reviewing this soon, had no chance so far as my week is unusually busy with Crisp.

valeriansaliou avatar May 22 '19 12:05 valeriansaliou

@valeriansaliou I've done some things and almost succeed. There is one thing that is still blocking asynchronous execution, but I have already plan how to solve it. Could you make a code review? Do I go in the right direction?

I could give your changes a quick look, and they look good to me. I'd say you can continue on this path!

valeriansaliou avatar May 23 '19 14:05 valeriansaliou

Great, I will!

perzanko avatar May 23 '19 14:05 perzanko

Keep me posted on your progress on this one, I have a bit more time for reviews :)

valeriansaliou avatar Jun 03 '19 16:06 valeriansaliou

Fine, I need to find some time

perzanko avatar Jun 04 '19 08:06 perzanko

There are conflicts to resolve, and probably some changes might be required due to the latest Rust async improvements.

XVilka avatar Oct 08 '19 08:10 XVilka