Valentas

Results 180 comments of Valentas

I already tried gpm-click event, but couldnt find easy solution. So far click works well even show warning in console. Despite all i agree that gpm-click should be supported. When...

I have no idea why event.target return null. tryParseJson function ~73 line. Even tho click event return position. Maybe try find element id and select position from html element itself.

I am 99% sure you are right. Will double check. I think it is easy/minor change.

Not sure if it is good idea to add to EventEntityBase since name say it is event entity and all methods are around event. I introduces interface IMapElement with set/get...

I am not sure should i add IAsyncDisposable to IMapElement. You could do just additional check. If i got you right.

LocationBias is only class which implements OneOfBase. Could be that functionality was lost after migration to System.Text.Json Second probably it is workaround (solution) to write like this ``` public OneOf?...

How this is this library issue? I dont know which part to fix

You could check issue history and mention people who has commented on similar parts.

This looks big. Sorry but it will take time. Try review at most in week or two.