valence icon indicating copy to clipboard operation
valence copied to clipboard

packet_inspector: fix UnexpectedEof errors deep inside packet decoding causing perfectly good connections to be aborted. fixes #64

Open dyc3 opened this issue 3 years ago • 3 comments

fixes #64

Test plan

start a vanilla mc server

docker run -e EULA=TRUE -e ONLINE_MODE=false -d -p 25565:25565 --name mc itzg/minecraft-server

run packet inspector

cargo r -r -p packet_inspector -- 127.0.0.1:25566 127.0.0.1:25565

Open mc and connect to localhost:25566 See that you can load into the world and play as normal.

dyc3 avatar Sep 15 '22 15:09 dyc3

Need to investigate further to make sure this doesn't cause issues elsewhere.

What are the implications for #54 ?

rj00a avatar Sep 16 '22 03:09 rj00a

I don't think it would affect #54 at all? This is just a change to the packet inspector, not to valence itself. Funnily enough, I can't seem to reproduce that issue with this setup.

dyc3 avatar Sep 16 '22 12:09 dyc3

Oh I misread. My bad.

rj00a avatar Sep 16 '22 12:09 rj00a

Don't think this is needed anymore due to #146. Closing.

rj00a avatar Nov 01 '22 09:11 rj00a