valence icon indicating copy to clipboard operation
valence copied to clipboard

Enchantment handler and improving ItemStack

Open justmangoou opened this issue 1 year ago • 2 comments

Describe the problem related to your feature request.

I believe that valence used to have enchantment parser around a year ago. However, I'm unable to find this or anything that similar to it now.

What solution would you like?

I think a valenece_enchant module would be a great solution. But, considering moving ItemStack and ItemKind out of the valence_core package and place enchantment handler inside.

What alternative(s) have you considered?

Reading NBT from ItemStack manually, but it didn't end up well.

Additional context

Nothing

justmangoou avatar Jul 14 '23 04:07 justmangoou

I think it would be preferable to create the valence_item crate and to create a parser for the nbt.

Bafbi avatar Aug 04 '23 17:08 Bafbi

I think I can make a PR for this

justmangoou avatar Aug 06 '23 02:08 justmangoou